[Bug 454207] Review Request: Terminator - Multiple terminals in one window

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Terminator - Multiple terminals in one window


https://bugzilla.redhat.com/show_bug.cgi?id=454207





------- Additional Comments From amdunn at gmail.com  2008-07-10 08:54 EST -------
I can't do an official review (I'm in need of sponsorship myself!), but I have
looked at what will come up under a review:

X rpmlint is not silent:

terminator.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/terminatorlib/version.py 0644
terminator.noarch: E: wrong-script-interpreter
/usr/lib/python2.5/site-packages/terminatorlib/freebsd.py "/usr/local/bin/python"

(Perhaps freebsd.py shouldn't even appear in the Fedora RPM, you can direct the
spec file to not install that)

terminator.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/terminatorlib/freebsd.py 0644
terminator.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/terminatorlib/config.py 0644
terminator.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/terminatorlib/encoding.py 0644
terminator.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/terminatorlib/terminator.py 0644
terminator.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/terminatorlib/terminatorterm.py 0644

It seems that you create a terminator script already in /usr/bin, and that the
rest of the files /usr/lib could do without the #! notation (and this would fix
the problem).

- package name seems alright
- licensing information formatted correctly and matches project license
- md5 matches upstream
- spec file legible, in American English

However, I would change the description. From the way it was written I didn't
even realize it was for GNOME terminals (I originally thought it was like
screen.) You could use (from upstream):

Terminator is a program that allows users to set up flexible arrangements of
GNOME terminals. It is aimed at those who normally arrange lots of terminals
near each other, but don't want to use a frame based window manager.

- Builds on at least one supported platform (checked on i386)
- Locales appear to be handled properly (with %find_lang), though I'm not an
expert on this issue, so someone else's opinion would be better here
- Runs rm -rf %{buildroot} in %clean, %install
X Macro usage inconsistent:

You use $RPM_BUILD_ROOT in some places and %{buildroot} in others. You need to
use only one, I recommend the second one.
- Has a .desktop file installed with desktop-file-install

Shoulds:
- Builds in mock
- Actually runs

So, all in all, you have only a few relatively minor issues that I can see, but
as I'm fairly new to this game a second opinion, for example, that of the person
who will be doing the official review, would probably be good.

PS - "The robot future of terminals" is a pun based on the name of the project -
about Terminator the movie series :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.