[Bug 454207] Review Request: Terminator - Multiple terminals in one window

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Terminator - Multiple terminals in one window


https://bugzilla.redhat.com/show_bug.cgi?id=454207





------- Additional Comments From pingou at pingoured.fr  2008-07-10 10:26 EST -------
(In reply to comment #8)
> X rpmlint is not silent:
> 
> terminator.noarch: E: non-executable-script
> /usr/lib/python2.5/site-packages/terminatorlib/version.py 0644
> terminator.noarch: E: wrong-script-interpreter
> /usr/lib/python2.5/site-packages/terminatorlib/freebsd.py "/usr/local/bin/python"
> 
> (Perhaps freebsd.py shouldn't even appear in the Fedora RPM, you can direct the
> spec file to not install that)
> 
> terminator.noarch: E: non-executable-script
> /usr/lib/python2.5/site-packages/terminatorlib/freebsd.py 0644
> terminator.noarch: E: non-executable-script
> /usr/lib/python2.5/site-packages/terminatorlib/config.py 0644
> terminator.noarch: E: non-executable-script
> /usr/lib/python2.5/site-packages/terminatorlib/encoding.py 0644
> terminator.noarch: E: non-executable-script
> /usr/lib/python2.5/site-packages/terminatorlib/terminator.py 0644
> terminator.noarch: E: non-executable-script
> /usr/lib/python2.5/site-packages/terminatorlib/terminatorterm.py 0644
> 
> It seems that you create a terminator script already in /usr/bin, and that the
> rest of the files /usr/lib could do without the #! notation (and this would fix
> the problem).
> 

I do not agree, these are python script, so they have to be executable, rpmlint
detect the shebang but the executable right this is why it is complainning, a
simple chmod +x solves the question.

There is also a wrong shebang that have to be changed via sed most probably...
The question of the presence of freebsd.py could indeed be asked. The best way
would be to test wether the program really needs it (vs crash without)

> However, I would change the description. From the way it was written I didn't
> even realize it was for GNOME terminals (I originally thought it was like
> screen.) You could use (from upstream):
> 
> Terminator is a program that allows users to set up flexible arrangements of
> GNOME terminals. It is aimed at those who normally arrange lots of terminals
> near each other, but don't want to use a frame based window manager.

hm does not work under KDE ??
Does it really requires this specification ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.