[Bug 454207] Review Request: Terminator - Multiple terminals in one window

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Terminator - Multiple terminals in one window


https://bugzilla.redhat.com/show_bug.cgi?id=454207





------- Additional Comments From amdunn at gmail.com  2008-07-10 21:00 EST -------
(In reply to comment #9)
> (In reply to comment #8)
> > X rpmlint is not silent:
> > 
> > terminator.noarch: E: non-executable-script
> > /usr/lib/python2.5/site-packages/terminatorlib/version.py 0644
> > terminator.noarch: E: wrong-script-interpreter
> > /usr/lib/python2.5/site-packages/terminatorlib/freebsd.py
"/usr/local/bin/python"
> > 
> > (Perhaps freebsd.py shouldn't even appear in the Fedora RPM, you can direct the
> > spec file to not install that)
> > 
> > terminator.noarch: E: non-executable-script
> > /usr/lib/python2.5/site-packages/terminatorlib/freebsd.py 0644
> > terminator.noarch: E: non-executable-script
> > /usr/lib/python2.5/site-packages/terminatorlib/config.py 0644
> > terminator.noarch: E: non-executable-script
> > /usr/lib/python2.5/site-packages/terminatorlib/encoding.py 0644
> > terminator.noarch: E: non-executable-script
> > /usr/lib/python2.5/site-packages/terminatorlib/terminator.py 0644
> > terminator.noarch: E: non-executable-script
> > /usr/lib/python2.5/site-packages/terminatorlib/terminatorterm.py 0644
> > 
> > It seems that you create a terminator script already in /usr/bin, and that the
> > rest of the files /usr/lib could do without the #! notation (and this would fix
> > the problem).
> > 
> 
> I do not agree, these are python script, so they have to be executable, rpmlint
> detect the shebang but the executable right this is why it is complainning, a
> simple chmod +x solves the question.

I believe that's only the case if you are actually running the files like
executables at the command line. However, the purpose of these files is to be
imported by the terminator program, which is in /usr/bin. It seems to be general
practice to keep files in the python site-packages as 0644, and it seems that
for scripting languages the goal is to keep only modules (for example, for Perl,
.pm files) in the library (%{_libdir}) directory.

That's not to say that it hasn't been done the other way too... in fact, rpmlint
seems to complain about some of the source RPMs that one can download that are
already in the repositories... (so I would guess that folks are somewhat
permissive about this point or were at some point in the past.) However, the
vast majority appear to be with non-shebanged files in %{_libdir} - one of the
main violators seems to be python files in the python package itself.

The program runs with all those shebangs eliminated, and furthermore, with
freebsd.py and related files eliminated.

> There is also a wrong shebang that have to be changed via sed most probably...
> The question of the presence of freebsd.py could indeed be asked. The best way
> would be to test wether the program really needs it (vs crash without)
> 
> > However, I would change the description. From the way it was written I didn't
> > even realize it was for GNOME terminals (I originally thought it was like
> > screen.) You could use (from upstream):
> > 
> > Terminator is a program that allows users to set up flexible arrangements of
> > GNOME terminals. It is aimed at those who normally arrange lots of terminals
> > near each other, but don't want to use a frame based window manager.
> 
> hm does not work under KDE ??
> Does it really requires this specification ?

That is a good point, I copied that description from upstream, but I just wanted
to make the point that it requires X windows.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.