[Bug 448201] Review Request: pyvnc2swf - Vnc screen recorder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyvnc2swf - Vnc screen recorder


https://bugzilla.redhat.com/show_bug.cgi?id=448201





------- Additional Comments From michel.sylvan at gmail.com  2008-07-15 10:36 EST -------
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

MUST, needs work:
• rpmlint: using rm in %preun. See below
• license field accurate: from the headers, this should be GPLv2+ not GPLv2
• own all directories: need to Require: hicolor-icon-theme for app icon

SHOULD, needs work:
• scriplets are sane: using rm in %preun. Does not seem to be necessary, as
  the files removed are listed in the package manifest (rpm -ql) and thus
  are removed automatically

MUST, OK:

• package name
• spec file name
• package guideline-compliant
• license complies with guidelines
• license file not deleted
• spec in US English
• spec legible
• source matches upstream: MD5 e871d134420867438cadd1f6320072f0
• builds under >= 1 archs, others excluded: noarch, builds
• build dependencies complete: yes
• no dupes in %files
• permission
• %clean RPM_BUILD_ROOT
• macros used consistently
• Package contains code
• doc not runtime dependent
• desktop file uses desktop-file-install
• clean buildroot before install
• filenames UTF-8

SHOULD, OK:
• package build in mock on all architectures:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=717372
• package functioned as described: yes
• require package not files
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEARECAAYFAkh8tc8ACgkQWt0J3fd+7ZAI5QCfRvPiBOLdA+1yRY6yfetRFpJ9
fh4AnjCA5F8CTGVQCyrJBKaGZzyoM+Ki
=jkzQ
-----END PGP SIGNATURE-----


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.