[Bug 448201] Review Request: pyvnc2swf - Vnc screen recorder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyvnc2swf - Vnc screen recorder


https://bugzilla.redhat.com/show_bug.cgi?id=448201





------- Additional Comments From dtimms at iinet.net.au  2008-07-15 19:14 EST -------
Created an attachment (id=311894)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=311894&action=view)
diff between last .spec and this

updated spec: http://members.iinet.net.au/~timmsy/pyvnc2swf/pyvnc2swf.spec
src.rpm: 
http://members.iinet.net.au/~timmsy/pyvnc2swf/pyvnc2swf-0.9.3-3.fc9.src.rpm

- del preun symbolic link removes - already done by files section
- add Requires hicolor-icon-theme, so that icon dir is owned correctly
- fix license tag to GPLv2+ since sources say: or later version
- fix some comments spelling

$ rpmlint SRPMS/pyvnc2swf-0.9.3-2.fc9.src.rpm 1 packages and 0 specfiles
checked; 0 errors, 0 warnings.

$ rpmlint --info RPMS/noarch/pyvnc2swf-0.9.3-3.fc9.noarch.rpm
pyvnc2swf.noarch: W: symlink-should-be-relative /usr/bin/vnc2swf
/usr/lib/python2.5/site-packages/pyvnc2swf/vnc2swf.py
Absolute symlinks are problematic eg. when working with chroot environments.

pyvnc2swf.noarch: W: symlink-should-be-relative /usr/bin/vnc2swf-edit
/usr/lib/python2.5/site-packages/pyvnc2swf/edit.py
Absolute symlinks are problematic eg. when working with chroot environments.

1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Michel: I did a bit of a search on absolute symlinks, and tried to make such
using symlinks -cs:
  http://rpmlint.zarb.org/cgi-bin/trac.cgi/ticket/25
, but that didn't resolve the rpm warning. Do you know if this is considered
normal to ignore, or can you point to a way to resolve it ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.