[Bug 445977] Review Request: ikiwiki - A wiki compiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ikiwiki - A wiki compiler


https://bugzilla.redhat.com/show_bug.cgi?id=445977


opensource at till.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |opensource at till.name
               Flag|                            |fedora-review?




------- Additional Comments From opensource at till.name  2008-06-07 17:55 EST -------
+ rpmlint: ok, warnings are about %{_exclude} sections

ikiwiki.src:100: E: hardcoded-library-path in
%{_prefix}/lib/w3m/cgi-bin/ikiwiki-w3m.cgi
ikiwiki.src:102: E: hardcoded-library-path in %{_prefix}/lib/ikiwiki/plugins

+ Naming: ok
+ License: ok, GPLv2+
+ Source file: ok, matches upstream:
6b293f6e8a08578533d0268b25dae5b3  ikiwiki_2.48.tar.gz
There was a new release just now:
http://git.ikiwiki.info/?p=ikiwiki;a=commitdiff;h=77edb81bee5a2c4966591d7ba1f3c83e31de272f
+ compiles on F8: ok
+ BuildRequires: ok, builds in F9 mock
+ Locale handling: ok, uses %find_lang
+ Libraries: ok, there are none
+ Directory Ownage: ok
+ Permissions: ok
+ %clean: ok
+ %install: ok

- License included: not ok, the license is included in ikiwiki/doc/GPL but not
in %doc
- Perl Requires: not ok

perl(File::MimeInfo) is twice in the requires of the rpm, it is added manually
in the spec, which I guess can be removed.

Also I would probably package ikiwiki-w3m.cgi, because it seems to be useful.

Another isssue is, that the directory %{_prefix}/lib/ikiwiki/plugins should be
probably created, to allow addon packages, that contain ikiwiki modules. Or
would the need the perl(RPC) dependency?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.