[Bug 445977] Review Request: ikiwiki - A wiki compiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ikiwiki - A wiki compiler


https://bugzilla.redhat.com/show_bug.cgi?id=445977





------- Additional Comments From thomas.moschny at gmx.de  2008-06-16 04:11 EST -------
Spec URL: http://thm.fedorapeople.org/ikiwiki.spec
SRPM URL: http://thm.fedorapeople.org/ikiwiki-2.50-1.fc9.src.rpm

%changelog
* Sun Jun 15 2008 Thomas Moschny <thomas.moschny at gmx.de> - 2.50-1
- Update to 2.50.
- Move ikiwiki-w3m.cgi into a subpackage.
- Add ikiwiki's own documentation.
- Remove duplicate requirement perl(File::MimeInfo).
- Minor cleanups.

(In reply to comment #3)
> + Source file: ok, matches upstream:
> 6b293f6e8a08578533d0268b25dae5b3  ikiwiki_2.48.tar.gz
> There was a new release just now:

Updated to 2.50.

> - License included: not ok, the license is included in ikiwiki/doc/GPL but not
> in %doc

Forgot to add ikiwiki's own documentation, fixed (html dir in %doc). This also
includes the GPL file.

> - Perl Requires: not ok
> 
> perl(File::MimeInfo) is twice in the requires of the rpm, it is added manually
> in the spec, which I guess can be removed.

Fixed.

> Also I would probably package ikiwiki-w3m.cgi, because it seems to be useful.

Included in a subpackage now.

> Another isssue is, that the directory %{_prefix}/lib/ikiwiki/plugins should be
> probably created, to allow addon packages, that contain ikiwiki modules. Or
> would the need the perl(RPC) dependency?

Yes it would. This directory is for non-perl plugins ikiwiki talks to using
xmlrpc, as far as I understood. As soon as there is perl(XML), I'm going to
include that dir and probably the demo plugins.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.