[Bug 450975] Review Request: libcanberra - Portable Sound Event Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libcanberra - Portable Sound Event Library


https://bugzilla.redhat.com/show_bug.cgi?id=450975





------- Additional Comments From mclasen at redhat.com  2008-06-12 11:25 EST -------
going down the checklist:

package name: ok
spec file name: ok
packaging guidelines: see above for things rpmlint found. beyond that, the 
  devel package needs to require pkg-config because it contains pc files 
  and gtk-doc because it contains stuff in /usr/share/gtk-doc/help
license: ok
license field: ok
license file: must be included
spec file language: ok
spec file legibility: ok
upstream sources: ok
buildable: yes
excludearch: n/a
build deps: ok
locale handling: ok
ldconfig: ok
relocatable: n/a
directory ownership: ok
duplicate files: ok
file permissions: ok
%clean: ok
macro use: consistent
content: permissible
large docs: ok
%doc content: ok
headers: ok
static libs: n/a
pc files: must add Requires: pkgconfig to -devel
shared libs: see above, libcanberra-foo.so should be moved out of /usr/lib
devel deps: ok
libtool archives: ok
gui apps: n/a
file ownership: ok
%install: ok
utf8 filenames: ok








-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.