[Bug 450975] Review Request: libcanberra - Portable Sound Event Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libcanberra - Portable Sound Event Library


https://bugzilla.redhat.com/show_bug.cgi?id=450975





------- Additional Comments From lpoetter at redhat.com  2008-06-12 11:28 EST -------
> [mclasen at localhost ~]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm
> libcanberra.i386: W: no-documentation
> 
> You should include at least
> %doc README LGPL

Fixed.

> libcanberra.i386: E: invalid-soname /usr/lib/libcanberra-pulse.so
> libcanberra-pulse.so
> libcanberra.i386: E: invalid-soname /usr/lib/libcanberra-null.so
libcanberra-null.so
> libcanberra.i386: E: invalid-soname /usr/lib/libcanberra-alsa.so
libcanberra-alsa.so
> 
> Are these plugins ? if so, they should not live in /usr/lib

Yes, they are plugins. Moving plugins to other directores is a pain to do in a
thread-safe manner with the mess that is ltdl, because you need to patch the
search path. I'd prefer leaving it the way it is for now. We can move that
around whenever we want in the future. Also, with the names chosen we shouldn't
be in risk of namespace clashes. And finally, having them in /usr/lib also
allows us to make use of the ld cache. Unless you really insist I'd prefer to
leave it the way it is right now.

> libcanberra-devel.i386: W: non-standard-group Development/C
> 
> Should just be Development/Libraries

Oops, seems to be a mandrivaism left-over from the original spec file I based my
work on.

Fixed, too.

Spec file is now updated.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.