[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel


https://bugzilla.redhat.com/show_bug.cgi?id=450539


fedora at christoph-wickert.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at christoph-wickert.de




------- Additional Comments From fedora at christoph-wickert.de  2008-06-29 11:07 EST -------
Not an official review, just a few thoughts:

I suggest to name this package gnome-applet-service-discovery, see
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28General.29

Better name a svn snapshot after the revision and not the date, because then the
reviewer can simply check out the correrct version with
svn co -rXXXXX svn://svn.0pointer.de/service-discovery-applet/trunk
service-discovery-applet

I see you define both python_sitelib and python_sitearch. Please remove the
unneeded definition.

You are missing a requirement:
$ service-discovery-applet 
Traceback (most recent call last):
  File "/usr/bin/service-discovery-applet", line 51, in <module>
    error_msg(_("A required python module is missing!\n%s") % (e))
  File "/usr/bin/service-discovery-applet", line 29, in error_msg
    d = gtk.MessageDialog(parent=None, flags=gtk.DIALOG_MODAL,
NameError: global name 'gtk' is not defined

running service-discovery-config gives a messagebox saying:
"Ein benötigtes Python Modul fehlt!
No module named avahi"

Not sure if we have a python-avahi package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.