[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel


https://bugzilla.redhat.com/show_bug.cgi?id=450539





------- Additional Comments From tim at niemueller.de  2008-06-29 18:43 EST -------
(In reply to comment #1)
> Not an official review, just a few thoughts:
> 
> I suggest to name this package gnome-applet-service-discovery, see
>
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28General.29

Hmm, this is different from upstream. My first search was for
service-discovery-applet so I wouldn't have found it with that name. Would yum
search provides lines to remedy this problem?

> Better name a svn snapshot after the revision and not the date, because then the
> reviewer can simply check out the correrct version with
> svn co -rXXXXX svn://svn.0pointer.de/service-discovery-applet/trunk
> service-discovery-applet

So you can with the date, just use svn co -r{DATE}... Having a date usually
makes it easier to get a feeling how up2date the package really is. I've used
this for other packages already. Just assume someone tried to do this on git or
cvs stuff...

> I see you define both python_sitelib and python_sitearch. Please remove the
> unneeded definition.

I usually keep it for easy spawning new packages by copying. I can't see in the
guidelines that I shouldn't.

> You are missing a requirement:
> $ service-discovery-applet 
> Traceback (most recent call last):
>   File "/usr/bin/service-discovery-applet", line 51, in <module>
>     error_msg(_("A required python module is missing!\n%s") % (e))
>   File "/usr/bin/service-discovery-applet", line 29, in error_msg
>     d = gtk.MessageDialog(parent=None, flags=gtk.DIALOG_MODAL,
> NameError: global name 'gtk' is not defined
> 
> running service-discovery-config gives a messagebox saying:
> "Ein benötigtes Python Modul fehlt!
> No module named avahi"
> 
> Not sure if we have a python-avahi package

Ah, needs to require avahi-tools, which contains the Python bindings for some
reason... Thanks for pointing this out!

I've uploaded a new SPEC (same URL as above) and new SRPM (at
http://fedorapeople.org/~timn/misc/service-discovery-applet-0.4.5-0.3.svn20080609.fc9.src.rpm).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.