[Bug 433135] Review Request: anyRemote - Bluetooth remote control

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: anyRemote - Bluetooth remote control


https://bugzilla.redhat.com/show_bug.cgi?id=433135


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-03-07 09:11 EST -------
* Source tarball
  - all source files in srpm should have 0644 permission.

* Source tarball
--------------------------------------------------------
1299641 2008-02-18 01:36 anyremote-4.3-2.fc8/anyremote-4.3.tar.gz
 933091 2008-03-05 03:57 anyremote-4.3-4.fc8/anyremote-4.3.tar.gz
1299122 2008-02-27 05:18 anyremote-4.3.tar.gz
--------------------------------------------------------
  - Source tarball changed.
    * If anyremove 4.3 is already published formally, don't use modified
      tarball and use the tarball we can actually download from URL
      written as Source0
    * Or can we assume that 4.3 is not formally pushed yet? (it seems
      you are the upstream developmer)

* Spec file name
  - must be "anyremote.spec", not "anyremote-fedora.spec".

* Dependency between subpackages
  - Dependency between subpackages usually must be EVR (Epoch:Version:Release)
    specific. i.e. usually "Requires: %{name}-data = %{name}-%{version}".

* CFLAGS
----------------------------------------------------------
make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"
----------------------------------------------------------
  - Check if this "CFLAGS=..." part really needed.
    (please check what %configure does by
     $ rpm --eval %configure again) This is usually not needed.

* Docdir
  - Usually we use %{_defaultdocdir}/%{name}-%{version}
    (not %{_defaultdocdir}/%{name}) for directory to install documents.
    Perhaps you want to remove all files under
    $RPM_BUILD_ROOT%{_defaultdocdir}/%{name} and just use %doc macro.

! * %changelog
  - By the way, we usually write %changelog at the last.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.