[Bug 433135] Review Request: anyRemote - Bluetooth remote control

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: anyRemote - Bluetooth remote control


https://bugzilla.redhat.com/show_bug.cgi?id=433135





------- Additional Comments From anyremote at mail.ru  2008-03-07 15:58 EST -------
(In reply to comment #20)

>   - all source files in srpm should have 0644 permission.
Umm... Checked. Which files do You mean ?

>     * Or can we assume that 4.3 is not formally pushed yet? 
Actually i'm releasing v4.4 right now.

>   - must be "anyremote.spec", not "anyremote-fedora.spec".
Done.

> * Dependency between subpackages
>     specific. i.e. usually "Requires: %{name}-data = %{name}-%{version}".
I separated package to "...-doc" and "...-data" intentionally to have
possibility to releasethem separately. So, actually "=" is not only possibly
variant.

>   - Check if this "CFLAGS=..." part really needed.
Done.

>   - Usually we use %{_defaultdocdir}/%{name}-%{version}
>     (not %{_defaultdocdir}/%{name}) for directory to install documents.
Documentation is not changed significantly beetwen releases. Also, as i wrote 
above it is possible to release "...-doc" subpackage separately, so it seems to
me there is no needs to specify it.

>   - By the way, we usually write %changelog at the last.
Done.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.