[Bug 254056] Review Request: e16 - The Enlightenment window manager, DR16

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: e16 -  The Enlightenment window manager, DR16


https://bugzilla.redhat.com/show_bug.cgi?id=254056


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From kevin at tummy.com  2008-03-25 19:39 EST -------
ok, first off... per spot's comment, would you be willing to ping upstream about
changing this license? Not a blocker, but it would be nice to fix it up moving
forward if possible. ;) 

rpmlint now says: 

e16.i386: E: zero-length /usr/share/e16/themes/winter/slideouts/slideouts.cfg
e16.i386: E: zero-length /usr/share/e16/themes/winter/buttons/buttons.cfg

Can leave those as we mentioned before... 

e16.i386: W: dangling-relative-symlink /usr/share/e16/themes/winter/ttfonts
../../../fonts/bitstream-vera

You sure that link is right? I think it might need another ../ there?

e16.i386: W: invalid-license MIT with advertising
e16.src: W: invalid-license MIT with advertising
e16-debuginfo.i386: W: invalid-license MIT with advertising

Can be ignored. 

The build options look ok for the most part, but I see: 

Experimental options - DO NOT USE unless you know what you are doing
  Compile with ecore/ecore_x ... no
  GLX .......................... no
  ScreenSaver .................. no
  D-Bus ........................ yes

Is D-Bus stable enough to use? If so, how about the others? 
Surely not a blocker. 

The only thing I see off hand to doublecheck is the link to the font. 
Can you check that and make sure it's right before checkin?

Otherwise, this package looks ok, and is APPROVED. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.