[Bug 254056] Review Request: e16 - The Enlightenment window manager, DR16

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: e16 -  The Enlightenment window manager, DR16


https://bugzilla.redhat.com/show_bug.cgi?id=254056


terjeros at phys.ntnu.no changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




------- Additional Comments From terjeros at phys.ntnu.no  2008-03-26 17:42 EST -------
(In reply to comment #16)
> ok, first off... per spot's comment, would you be willing to ping upstream
> about changing this license? Not a blocker, but it would be nice 
> to fix it up moving forward if possible. ;) 

Will send a mail to Kim.
 
> 
> e16.i386: W: dangling-relative-symlink /usr/share/e16/themes/winter/ttfonts
> ../../../fonts/bitstream-vera
> 
> You sure that link is right? I think it might need another ../ there?

It's correct (from a live system):

$ namei /usr/share/e16/themes/winter/ttfonts
f: /usr/share/e16/themes/winter/ttfonts
 d /
 d usr
 d share
 d e16
 d themes
 d winter
 l ttfonts -> ../../../fonts/bitstream-vera
   d ..
   d ..
   d ..
   d fonts
   d bitstream-vera
> The build options look ok for the most part, but I see: 
> 
> Experimental options - DO NOT USE unless you know what you are doing
>   Compile with ecore/ecore_x ... no
>   GLX .......................... no
>   ScreenSaver .................. no
>   D-Bus ........................ yes
> 
> Is D-Bus stable enough to use? If so, how about the others? 
> Surely not a blocker. 

DBUS is not listed as experimental in "configure --help"  while the others are,
uhm...

 
> The only thing I see off hand to doublecheck is the link to the font. 
> Can you check that and make sure it's right before checkin?

Yes,
 
> Otherwise, this package looks ok, and is APPROVED. 

Thanks, Kevin!



New Package CVS Request
=======================
Package Name: e16
Short Description: The Enlightenment window manager, DR16
Owners: terjeros
Branches: F-7 F-8 F-9
InitialCC:
Cvsextras Commits: yes





-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.