[Bug 459989] Review Request: gnurobots - A robot programming game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459989


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #11 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-11-02 09:22:08 EDT ---
For -3:

* For BuildRequires
  - libXft-devel is required by pango-devel
       and pango-devel is required by gtk2-devel
  - gtk2-devel is required by vte-devel
    so these are redundant.

Note:
(In reply to comment #1)
> The compilation requires libXft-devel, libXrender-devel, fontconfig-devel and
> freetype-devel. but it seems that those dependences should have been stated in
> the vte-devel package,

  - vte-devel requires gtk2-devel
       and gtk2-devel requires pango-devel
       and pango-devel requires 
           libXft-devel libXrender-devel fontconfig-devel freetype-devel

* Files under xpm/
--------------------------------------------------------------
%{__cp} -av xpm/ $RPM_BUILD_ROOT%{_datadir}/%{name}
--------------------------------------------------------------
  - I don't think xpm/Makefile{,am,in} are needed.

* Desktop file vendor suffix
  - Packaging guidelines changed and for new packages
    --vendor=fedora must not be used anymore:
    https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor

    ! If you want to maintain this package also on EPEL??,
      --vendor="" is needed (because EPEL uses old desktop-file-utils
      which won't accept desktop-file-install command without
      specifying vendor)

! %changelog
  - I recommend to put one line between each %changelog entry like:
---------------------------------------------------------------
* Thu Oct 30 2008 Vivek Shah <boni.vivek gmail.com> 1.2.0-3
- Fixed BuildRequires to remove unrequired dependencies
- Added missing unowned directories
- Added directive to use Fedora CFLAGS while building

* Mon Oct 14 2008 Vivek Shah <boni.vivek at gmail.com> 1.2.0-2
- Added desktop file, fixed new build requires

* Wed Aug 20 2008 Vivek Shah <boni.vivek gmail.com> 1.2.0-1
- Fixed permissions of files under scheme/ to 644 
---------------------------------------------------------------
    This is useful when you use "make clog" on Fedora CVS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.