[Bug 470424] Review Request: libtopology - Libtopology is a library for discovering the hardware topology on Linux systems

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 10 00:30:00 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470424


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs.michael at gmx.net




--- Comment #1 from Michael Schwendt <bugs.michael at gmx.net>  2008-11-09 19:29:59 EDT ---
$ rpmlint -i libtopology-0.3-0.1.fc9.src.rpm
libtopology.src: E: description-line-too-long Libtopology is a library for
discovering the hardware topology on Linux systems.
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.


* Licence is: LGPLv2   (not GPLv2)


* Use %{_libdir} not %prefix/_lib as %_libdir is /usr/lib64 for
64-bit multi-arch platforms.


* Prefer "cp -p" or "install -p" when installing files.


* /usr/share/doc/libtopology-0.3/  is not included.
(Hint: Run "rpm -qlvp" on the built packages and notice missing
directory entries.)


* Is it really desired to put the documentation into a separate package?
The pkg is not even 100K in size. I would add the docs to the -devel pkg.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list