[Bug 470424] Review Request: libtopology - Libtopology is a library for discovering the hardware topology on Linux systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470424





--- Comment #2 from Tony Breeds <tony at bakeyournoodle.com>  2008-11-09 20:09:30 EDT ---
Firstly thank you for takign the time to review my package.

(In reply to comment #1)
> $ rpmlint -i libtopology-0.3-0.1.fc9.src.rpm
> libtopology.src: E: description-line-too-long Libtopology is a library for
> discovering the hardware topology on Linux systems.
> Your description lines must not exceed 79 characters. If a line is exceeding
> this number, cut it to fit in two lines.

Ah thanks.  the rpmlint version in fc9 doesn't issue this warning. I've grabbed
the version from rawhide.
Fixed.
---
rpmlint -i SRPMS/libtopology-0.3-0.2.fc9.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
---

> * Licence is: LGPLv2   (not GPLv2)

So is is Fixed.

> * Use %{_libdir} not %prefix/_lib as %_libdir is /usr/lib64 for
> 64-bit multi-arch platforms.

I swear I tried that and the .so files were landing in /usr/lib (on 64-bit).
Fixed.

> * Prefer "cp -p" or "install -p" when installing files.

Fixed.  .... Is that documented somewhere I missed?

> * /usr/share/doc/libtopology-0.3/  is not included.
> (Hint: Run "rpm -qlvp" on the built packages and notice missing
> directory entries.)

Ahh thank you for the hint!

Fixed.

> * Is it really desired to put the documentation into a separate package?
> The pkg is not even 100K in size. I would add the docs to the -devel pkg.

Fixed. Moved to the -devel package.

New .specfile and .src.rpm at the same locations.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.