[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 10 00:38:21 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468631





--- Comment #3 from Michael Schwendt <bugs.michael at gmx.net>  2008-11-09 19:38:20 EDT ---
> %files
> %defattr(-,root,root,-)
> %doc AUTHORS COPYING INSTALL README TODO

Absolutely no need to include the same %doc files also in
the -devel pkg.

> %{_bindir}/gar*
> %{_datadir}/%{name}/garmintypes.txt

Don't forget the corresponding directory entry!
Add:  %dir %{_datadir}/%{name}

> %files devel
> %defattr(-,root,root,-)
> %doc AUTHORS COPYING INSTALL README TODO
> %{_datadir}/%{name}/doc/*

Here either replace your line with

   %{_datadir}/%{name}/doc/

to add that directory and its contents recursively, or add:

  %dir %{_datadir}/%{name}/doc

to the -devel pkg files section.

> %{_libdir}/pkgconfig/%{name}.pc

You put a file in there, so "Requires: pkgconfig".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list