[Bug 468631] Review Request: libgarmin - C library to parse and use Garmin image files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468631





--- Comment #4 from Fabian Affolter <fabian at bernewireless.net>  2008-11-10 15:06:28 EDT ---
(In reply to comment #3)
> > %files
> > %defattr(-,root,root,-)
> > %doc AUTHORS COPYING INSTALL README TODO
> 
> Absolutely no need to include the same %doc files also in
> the -devel pkg.

fixed

> > %{_bindir}/gar*
> > %{_datadir}/%{name}/garmintypes.txt
> 
> Don't forget the corresponding directory entry!
> Add:  %dir %{_datadir}/%{name}

fixed

> > %files devel
> > %defattr(-,root,root,-)
> > %doc AUTHORS COPYING INSTALL README TODO
> > %{_datadir}/%{name}/doc/*
> 
> Here either replace your line with
> 
>    %{_datadir}/%{name}/doc/
> 
> to add that directory and its contents recursively, or add:
> 
>   %dir %{_datadir}/%{name}/doc
> 
> to the -devel pkg files section.

fixed

> > %{_libdir}/pkgconfig/%{name}.pc
> 
> You put a file in there, so "Requires: pkgconfig".

fixed

SPEC: http://fab.fedorapeople.org/packages/SRPMS/libgarmin.spec
SRPM:
http://fab.fedorapeople.org/packages/SRPMS/libgarmin-0-0.3.20081026svn.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.