[Bug 467958] Review Request: barry - BlackBerry(tm) Desktop for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467958





--- Comment #7 from Hans de Goede <hdegoede at redhat.com>  2008-11-10 09:23:32 EDT ---
Getting there, getting there :)

Must FIX:
---------

* The Requires pkgconfig should be part of the -devel subpackage, not of the
main package

* Now that the libs are in barry-libs, barry-devel must require %{name}-libs =
%{version}-%{release}, not just %{name}

* Group for -libs should be: "Group: System Environment/Libraries"

* The Summary for the gui subpackage is wrong:
Summary: BlackBerry Desktop for Linux - bcharge, btool, breset and others
But bcharge, btool and breset are in the main package.

* These files and their matching Requires for dir ownership should be in the
-libs packages, as users can also install just the gui tools + libs and then
will still want to get these files:
%config(noreplace) %{_sysconfdir}/udev/rules.d/*
%config(noreplace) %{_sysconfdir}/security/console.perms.d/*
%config(noreplace) %{_sysconfdir}/modprobe.d/blacklist-berry_charge

* We do not ship static libraries, please remove this file after make install
instead of shipping it:
%{_libdir}/*.a
(My fault I didn't catch this the first time)

* I've tested it and using --disable-rpath does not work (it almost never
does), so please use the provided sed commands instead


Should FIX:
-----------
* Please indent "udev .." to the same level as all the settings of all the
other lines above this one:
Requires: udev pam module-init-tools initscripts pkgconfig

* As the -gui subpackage gets build unconditionally please move these
BuildRequires up to the main BuildRequires portion and indent it as "udev ..":
BuildRequires: gtkmm24-devel libglademm24-devel libglade2-devel libtar-devel
desktop-file-utils
Also note that you may use multiple BuildRequires lines below each other,
please do so and make all these lines fit within 80 chars

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.