[Bug 435018] Review Request: clipper - crystallographic object oriented library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=435018





--- Comment #17 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-11-14 03:31:35 EDT ---
For -18:

(In reply to comment #16)
> (In reply to comment #15)

> > * Directory ownership issue
> >   - %_includedir/clipper is not owned by any packages
> >     ref:
>
> Ah, thanks!  fixed.

  - This time build.log says:
------------------------------------------------------------
  2116  + exit 0
  2117  warning: File listed twice: /usr/include/clipper/ccp4
  2118  warning: File listed twice: /usr/include/clipper/ccp4/ccp4_map_io.h
  2119  warning: File listed twice: /usr/include/clipper/ccp4/ccp4_mtz_io.h
  2120  warning: File listed twice: /usr/include/clipper/ccp4/ccp4_mtz_types.h
  2121  warning: File listed twice: /usr/include/clipper/ccp4/ccp4_utils.h
  2122  warning: File listed twice: /usr/include/clipper/cif
------------------------------------------------------------
    As written on the wiki I quoted on my comment 15,
    %files entry
------------------------------------------------------------
%files
%{_includedir}/clipper
------------------------------------------------------------
    contains the directory %_includedir/clipper _and_ all
    files/directories/etc under %_includedir/clipper.

? Static linkage
  - The following command
------------------------------------------------------------
$ rpm -ql clipper | grep /usr/bin | xargs ldd -r
------------------------------------------------------------
    shows no binaries in clipper rpm under %_bindir do not depend
    on libclipper.so. This seems rather strange.

    For example, caniso binaries are created like:
------------------------------------------------------------
  1842  g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -fno-strict-aliasing -o caniso caniso.o 
../clipper/mmdb/.libs/libclippermmdb.a ../clipper/cif/.libs/libclippercif.a
../clipper/cns/.libs/libclippercns.a
../clipper/minimol/.libs/libclipperminimol.a
../clipper/phs/.libs/libclipperphs.a ../clipper/ccp4/.libs/libclipperccp4.a
-lgpp4 -lmmdb ../clipper/contrib/.libs/libclippercontrib.a
../clipper/core/.libs/libclippercore.a -lsrfftw -lsfftw -lm  
------------------------------------------------------------
    So these binaries use static libclipperXXXX.a. I guess these
    binaries should use system wide libclipper.so.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.