[Bug 435018] Review Request: clipper - crystallographic object oriented library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=435018





--- Comment #18 from Tim Fenn <fenn at stanford.edu>  2008-11-14 14:27:48 EDT ---
(In reply to comment #17)
> For -18:
> 
> (In reply to comment #16)
> > (In reply to comment #15)
> 
> > > * Directory ownership issue
> > >   - %_includedir/clipper is not owned by any packages
> > >     ref:
> >
> > Ah, thanks!  fixed.
> 
>   - This time build.log says:
> ------------------------------------------------------------
>   2116  + exit 0
>   2117  warning: File listed twice: /usr/include/clipper/ccp4
>   2118  warning: File listed twice: /usr/include/clipper/ccp4/ccp4_map_io.h
>   2119  warning: File listed twice: /usr/include/clipper/ccp4/ccp4_mtz_io.h
>   2120  warning: File listed twice: /usr/include/clipper/ccp4/ccp4_mtz_types.h
>   2121  warning: File listed twice: /usr/include/clipper/ccp4/ccp4_utils.h
>   2122  warning: File listed twice: /usr/include/clipper/cif
> ------------------------------------------------------------
>     As written on the wiki I quoted on my comment 15,
>     %files entry
> ------------------------------------------------------------
> %files
> %{_includedir}/clipper
> ------------------------------------------------------------
>     contains the directory %_includedir/clipper _and_ all
>     files/directories/etc under %_includedir/clipper.
> 

Sorry, I was rushing a bit - removed the extraneous entries.

> ? Static linkage
>   - The following command
> ------------------------------------------------------------
> $ rpm -ql clipper | grep /usr/bin | xargs ldd -r
> ------------------------------------------------------------
>     shows no binaries in clipper rpm under %_bindir do not depend
>     on libclipper.so. This seems rather strange.
> 

fixed Makefile.am for the examples

new spec: http://www.stanford.edu/~fenn/packs/clipper.spec
new srpm: http://www.stanford.edu/~fenn/packs/clipper-2.0-19.f8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.