[Bug 226235] Merge Review: pax

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226235


Orcan 'oget' Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |orcanbahri at yahoo.com
         AssignedTo|nobody at fedoraproject.org    |orcanbahri at yahoo.com
               Flag|                            |fedora-review?




--- Comment #1 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-11-20 01:50:31 EDT ---
I reviewed this package. Here is what needs to be done for compliance with the
guidelines:

* The doc files ABOUT-NLS, AUTHORS, ChangeLog, COPYING, NEWS, README, THANKS
need to be packaged.

* We prefer %defattr(-,root,root,-)

* Buildroot must be one of these:
   %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
   %{_tmppath}/%{name}-%{version}-%{release}-root

* It would be nice if you explain in the SPEC file what the patches do. The
project seems dead, I don't think there is any place to submit the patches to.

* Parallel make should be supported whenever possible. If it is not supported,
this should be noted in the SPEC file as a comment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.