[Bug 472337] Review Request: fabric - A simple pythonic remote deployment tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472337





--- Comment #5 from Silas Sewell <silas at sewell.ch>  2008-11-20 21:45:43 EDT ---
(In reply to comment #4)
> Please bump the release of your spec file if you made any changes and add a
> changelog entry. 

Fixed.

> fabric.noarch: E: non-executable-script
> /usr/lib/python2.5/site-packages/fabric.py 0644

fabric.py is never called directly (and would not do anything if it was) and
site-packages modules generally don't have the executable permission.

This issue was also raised in this request:
https://bugzilla.redhat.com/show_bug.cgi?id=351251

Example:

[ssewell at gm ~]$ ll /usr/lib/python2.5/site-packages/*.py
-rw-r--r-- 1 root root 14299 2008-04-03 10:14
/usr/lib/python2.5/site-packages/aotcompile.py
-rw-r--r-- 1 root root 32345 2008-08-25 15:06
/usr/lib/python2.5/site-packages/audit.py
-rw-r--r-- 1 root root 10245 2008-07-03 05:36
/usr/lib/python2.5/site-packages/augeas.py
-rw-r--r-- 1 root root  7389 2006-08-22 08:18
/usr/lib/python2.5/site-packages/classfile.py
-rw-r--r-- 1 root root    33 2008-08-05 00:05
/usr/lib/python2.5/site-packages/dbus_bindings.py
...

> I'm able to build this package without 'Requires: python-setuptools'.  But I'm
> not very familiar with the *.egg stuff.  I thought that 'BuildRequires:
> python-setuptools-devel' is responsible for providing the egg.

You are correct, but the requirement comes from the import of pkg_resources in
the "fab" command. If python-setuptools is not installed on the local machine
the "fab" command will not run.

/usr/bin/fab:

  5 from pkg_resources import load_entry_point
  6 
  7 sys.exit(
  8    load_entry_point('Fabric==0.0.9', 'console_scripts', 'fab')()
  9 )

PkgResources: http://peak.telecommunity.com/DevCenter/PkgResources

== Updated Media ==

Spec URL:
http://silassewell.googlecode.com/svn/trunk/projects/rpm/fabric/fabric.spec
SRPM URL:
http://silassewell.googlecode.com/svn/trunk/projects/rpm/fabric/fabric-0.0.9-3.fc9.src.rpm

Thanks again,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.