[Bug 462251] Review Request: PyMOL - python molecular graphics

bugzilla at redhat.com bugzilla at redhat.com
Sat Oct 18 16:02:59 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462251





--- Comment #32 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-18 12:02:58 EDT ---
For -7:

(In reply to comment #31)
> (In reply to comment #30)
> > * Python module dependency
> >   - Would you check python module dependency again?
> >     For example pmg_tk/startup/apbs_tools.py says
> >     so this script requires tkinter (note: tkinter
> >     requires tk and tcl)
> Right, but python-pmw pulls tkinter in already.

  - Ah, okay. Thanks.

> >     And another example is that pmg_wx/__init__.py,
> >     This scripts requires wxPython.
> >     However these dependencies may be optional and
> >     I am not sure what python modules pymol requires
> >     _at least_.
> wxPython can be used as an alternative to tcl/tk, but is optional.  I guess in
> which case the pmg_wx module should be removed?
  - No need to remove. However it is also a good idea to create a subpackage
    (like -wxpython), then split wxPython related files to that subpackage.

> > * optflags
> >   - build.log still says that compiler options "-ffast-math -funroll-loops -O3"
> >     are used:
> doh!  Fixed.
  - Well, about how to apply a patch in the spec file see
    the explanation
    http://docs.fedoraproject.org/drafts/rpm-guide-en/ch09s04.html
    and the example:
    http://cvs.fedoraproject.org/viewvc/rpms/pcmanfm/devel/pcmanfm.spec?view=co

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list