[Bug 462251] Review Request: PyMOL - python molecular graphics
bugzilla at redhat.com
bugzilla at redhat.com
Sat Oct 18 23:31:34 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462251
--- Comment #33 from Tim Fenn <fenn at stanford.edu> 2008-10-18 19:31:33 EDT ---
(In reply to comment #32)
> For -7:
>
> (In reply to comment #31)
> > (In reply to comment #30)
> > > And another example is that pmg_wx/__init__.py,
> > > This scripts requires wxPython.
> > > However these dependencies may be optional and
> > > I am not sure what python modules pymol requires
> > > _at least_.
> > wxPython can be used as an alternative to tcl/tk, but is optional. I guess in
> > which case the pmg_wx module should be removed?
> - No need to remove. However it is also a good idea to create a subpackage
> (like -wxpython), then split wxPython related files to that subpackage.
>
Good idea - done in -8.
> > > * optflags
> > > - build.log still says that compiler options "-ffast-math -funroll-loops -O3"
> > > are used:
> > doh! Fixed.
> - Well, about how to apply a patch in the spec file see
> the explanation
> http://docs.fedoraproject.org/drafts/rpm-guide-en/ch09s04.html
> and the example:
> http://cvs.fedoraproject.org/viewvc/rpms/pcmanfm/devel/pcmanfm.spec?view=co
Ah, thanks. Fixed.
spec url: http://www.stanford.edu/~fenn/packs/pymol.spec
srpm url:
http://www.stanford.edu/~fenn/packs/pymol-1.1-8.20081015svn3468.f8.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list