[Bug 498125] Review Request: lxde-settings-daemon - XSettings Daemon for LXDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498125





--- Comment #2 from Christoph Wickert <fedora at christoph-wickert.de>  2009-04-29 09:41:28 EDT ---
(In reply to comment #1)
> - Require system-icon-theme instead of fedora-icon-theme, as one should be able 
> to remove Fedora brandings altogether.

The reason for choosing fedora-icon-theme over system-icon-theme is that I
explicitly set Fedora in the patch. Changed.

> - Is the obsoletes&provides really necessary since there AFAIK is not and
> hasn't ever been a lxde-settings package in Fedora?

You are correct. I made one as a subpackage of the current lxde-common, but I
never built it. Removed.

> - lxde-settings-daemon.c is under GPLv2+, other files are under MIT.
> - I'm not sure, however, if the MIT license needs to be mentioned since it's
compatible with GPLv2+.

Agreed and removed. BTW: The included COPYING is GPLv3, not v2. Upstream
confirmed this was an error. You want me to replace the file in the package or
leave it as is for now.

> - Package already Requires: lxde-common which provides /usr/share/lxde =>
> remove
>  %dir %{_datadir}/lxde/

That was intentional. I omitted the dir from lxde-common-0.4 and made it
require lxde-settings-daemon instead.


Updated package:
SPEC: http://cwickert.fedorapeople.org/review/lxde-settings-daemon.spec
SRPM:
http://cwickert.fedorapeople.org/review/lxde-settings-daemon-0.4-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.