[Bug 498125] Review Request: lxde-settings-daemon - XSettings Daemon for LXDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498125


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-04-29 10:01:43 EDT ---
(In reply to comment #2)
> > - lxde-settings-daemon.c is under GPLv2+, other files are under MIT.
> > - I'm not sure, however, if the MIT license needs to be mentioned since it's
> compatible with GPLv2+.
> 
> Agreed and removed. BTW: The included COPYING is GPLv3, not v2. Upstream
> confirmed this was an error. You want me to replace the file in the package or
> leave it as is for now.

Leave it as it is. The license of the program is the one in the source code.

> > - Package already Requires: lxde-common which provides /usr/share/lxde =>
> > remove
> >  %dir %{_datadir}/lxde/
> 
> That was intentional. I omitted the dir from lxde-common-0.4 and made it
> require lxde-settings-daemon instead.

Oh, okay, no problem then.

**

The package has been

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.