[Bug 479594] Review Request: email - A command line SMTP client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479594


Thomas Spura <spurath at students.uni-mainz.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |spurath at students.uni-mainz.
                   |                            |de




--- Comment #4 from Thomas Spura <spurath at students.uni-mainz.de>  2009-08-06 16:10:52 EDT ---
I'm no packager, reviewing this as learning guidelines by reviewing others

MUST: rpmlint
already posted, ok
MUST: spec file is %{name}.spec
ok
MUST: Fedora approved license
GPLv2+, ok
MUST: License field in the package spec file must match the actual license
ok
MUST: %doc %{license}
it is, ok
MUST: %doc files not important for runtime
ok
MUST: spec file in American English
ok
MUST: spec file legible
ok
MUST: souces must match upstream source
md5: cc51aeaa749d787915e8aa9bcd580c5d, ok
MUST: packages compiles succesfully
does, ok
MUST: build dependencies listed in BuildRequires
ok
MUST: locale handling with %find_lang
no locales, ok
MUST: shared libraries must call ldconfig in %post and %postun
ok
MUST: owns each directory it creates
ok
MUST: don't list a file more than once in %files listening
ok
MUST: %clean rm -rf %{buildroot}
ok
MUST: consistently using macros
partly ok, see further down
MUST: The package must contain code, or permissable content.
ok
MUST: large documentation files must go in a -doc subpackage
not large, ok
MUST: header files must be in a -devel package
no header, ok
MUST: libraries with ending .so must be in -devel package
ok
MUST: -devel must Requires: %{name} = %{version}-%{release}
ok
MUST: static libraries must be in a -static package
ok
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.
ok
MUST: .la libtool archive are forbitten
ok
MUST: Packages containing GUI applications must include a %{name}.desktop file
      and desktop-file-install in %install;
      no %{name}.desktop -> reason explained in %{name}.spec
no gui, ok
MUST: Packages must not own files or directories already owned by other
packages
ok
MUST: beginning of %install rm -rf %{buildroot}
ok
MUST: All filenames in rpm packages must be valid UTF-8.
ok

MUST: permissions properly set
probably ok, as just copying, *but*:

The Makefile installs the programm in the wrong place!
See prefix = /usr/local
and not prefix = /usr
As a test with make install DESTDIR=tmp INSTALL="install -p" is wrong, but
within the spec, anything behaves correctly (->prefix = /usr). Don't see why.
But ok ;-)

The name email should be ok for me. There already exists email2trac, deletemail
and archivemail. Furthermore email reflects, what the program does. This kind
of common namespace should be avoided, but here not possible. How could it
renamed? 'send' or whatever? yum search mail is much bigger than yum search
email atm…

No blocker, I'd approve this, if I could ;-)
(After the explanation of my the makefile problem, of course^^)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.