[Bug 479594] Review Request: email - A command line SMTP client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479594


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #5 from Ralf Corsepius <rc040203 at freenet.de>  2009-08-07 03:21:58 EDT ---
(In reply to comment #4)

> As a test with make install DESTDIR=tmp INSTALL="install -p" is wrong, but
> within the spec, anything behaves correctly (->prefix = /usr). Don't see why.

Probably one or more of these:
a) DESTDIR must be an absolute directory. A relative dir (DESTDIR=tmp) will
never work.
b) You didn't pass the options, rpmbuild'ing applies, to configure.

> The name email should be ok for me.
Not for me - I consider this package's name, the binary's name and the
config-files's names to be a short-sighted (silly?) upstream decision.


> How could it renamed?
* After the author (Dean Jones): djmail, deansmail
* After the author's site (cleancode.org): cleanmail, cleancode.org-mail
... Bonzo?

If this package was fully supporting autoconf, --program-prefix could be used
as escape - Unfortunately this package doesn't.

> No blocker, I'd approve this, if I could ;-)
> (After the explanation of my the makefile problem, of course^^)  

Other issues:

1) The package doesn't honor $INSTALL => Besides the fact that
make "INSTALL=install -p" is almost always meaningless, 
it is completely non-functional in this particular case.

2) The package tarball contains autom4te.caches. Shiping only adds bloat to a
tarball and is hardly of any use.

3) The package seems to support ssl/tls, but is compiled without it 
(c.f. configure --help, check --with-ssl)

4) The sources contains excerpts from RFCs.
c.f. files: RFC821, rfc3156-openpgp.txt, quoted-printable.rfc
Normally RFCs are distributable for free when "being properly credited".

I am not sure if this consideration applies to the files as being shipped with
this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.