[Bug 503013] Review Request: gnaughty - Downloader for adult content

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503013





--- Comment #27 from Simon Wesp <cassmodiah at fedoraproject.org>  2009-08-07 04:18:46 EDT ---

(In reply to comment #26)

> SHOULD Items:
> Items marked as SHOULD are things that the package (or reviewer) SHOULD do,
> but is not required to do.


> SHOULD: The reviewer should test that the package functions as described. A
> package should not segfault instead of running, for example.
>
> This is running. But work very strange - on download page appeared "dead"
> unfinished downloads. On "Delete finished" press some finished not deleted...
> I think you must fill bug on it to upstream. I will not do it as 
> stop - problem for review, but if you don't do it now, 
> I'll submit bug to gnaughty.
I already sent an email to upstream (no trac or bz). I found more bugs, and
even #504247 is mailed to upstream.

> SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague,
> and left up to the reviewers judgement to determine sanity.
> 
> No.
> In configure you forgot --disable-schemas-install.
> In %pre and %post "killall -HUP gconfd-2 || :"
> 
> In %post: "%{_sysconfdir}/gconf/schemas/%{name}.schemas > /dev/null || :"
> 
> Please see:
> https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GConf
> 
1.) Scriplet _is_ sane
2.) It's a SHOULD-item
3.) It's a draft 
4.) "%configure --disable-schema-install" and "export
GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1 make install" are equal
5.) and 4.) should be conform to current guidelines

> So, package is very well. Please, fix scriptlets and it will be approved.  
as this is 
1.) a should item
2.) working
i can't understand your block!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.