[Bug 503013] Review Request: gnaughty - Downloader for adult content

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503013





--- Comment #28 from Christoph Wickert <fedora at christoph-wickert.de>  2009-08-07 05:01:01 EDT ---
(In reply to comment #26)

> In configure you forgot --disable-schemas-install.

Simon already has 
make install DESTDIR=%{buildroot} INSTALL="install -p"
This is an ether - or thing: You only need one, but not both.

> In %pre and %post "killall -HUP gconfd-2 || :"

This should no longer be used as it not necessary in any of the supported
Fedora releases but only in RHEL 4. I doubt that Simon wants to package this
for RHEL 4.

> In %post: "%{_sysconfdir}/gconf/schemas/%{name}.schemas > /dev/null || :"
> 
> Please see:
> https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GConf

The official scriptlets as ratified by the packaging committee is at
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf
and Simon's uses exactly the same scriptlets as from the wiki.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.