[Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543337





--- Comment #2 from Matthew Kent <mkent at magoazul.com>  2009-12-04 00:48:02 EDT ---
Thank you for the review

(In reply to comment #1)
> Some notes:
> 
> ? Requires
>   - Would you explain the necessity of "R: rubygem(rake)"?
>     ( Maybe for lib/rcov/rcovtask.rb ? If so, I wonder if this
>       script is used by default or not because no other scripts
>       in rcov gem seems to require this script )
> 
>   ! Note that I am not objecting to adding "R: rubygem(rake)".
> 

That's correct, I added that in an attempt to cover what I thought was a
missing dependency. Upon a further examination lib/rcov/rcovtask.rb provides
tasks *to* rake rather than depending *on* rake. I'll remove that.

> * ext/
>   - Files under ext/ are to generate C extension module
>     (rcovrt.so) and should not be needed to be included into
>     binary rpm.
> 
>     ( The trouble is that once we try to execute "rake check"
>       under %geminstdir, rake task tries to regenerate .so file.
> 
>       In such cases files under ext/ are needed, however anyway
>       this won't work but for root because write permission for
>       %geminstdir is needed.
>       So while you may want to add files under ext to -doc
>       subpackage, these files should not be in main package. )  

Good catch, thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.