[Bug 548092] Review Request: shared-color-targets - Color targets from vendors for color calibration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548092


Richard Hughes <rhughes at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rhughes at redhat.com




--- Comment #3 from Richard Hughes <rhughes at redhat.com>  2009-12-18 06:02:33 EDT ---
(In reply to comment #2)
> * Provide downloadable Source0

Done.

> * Fix License field in spec-file

Done

> * Package must own %{_datadir}/color/targets dir

Done

> * Relocate docs related to Wolf Faust's work.  

Not done. Programs such as gnome-color-manager are expecting them to be in
/usr/share/share-color-targets/$(VENDOR)/{README|LICENSE} -- this is so the
user can click a link to the target readme or licence in the GUI and it will be
displayed automatically. They shouldn't be listed as doc files as if they are
missing then clients can't display the licence of the targets, which is bad.

I hope this is okay, as functionality in the GUI client depends on the fact
they are present, and named in this way.

Richard.

New spec file:
http://people.freedesktop.org/~hughsient/temp/shared-color-targets.spec
New SRPM:
http://people.freedesktop.org/~hughsient/temp/shared-color-targets-0.0.1-0.7.20091218git.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.