[Bug 548092] Review Request: shared-color-targets - Color targets from vendors for color calibration

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 18 11:35:43 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548092





--- Comment #4 from Peter Lemenkov <lemenkov at gmail.com>  2009-12-18 06:35:42 EDT ---
(In reply to comment #3)

+ The sources used to build the package, match the upstream source, as provided
in the spec URL.

[petro at Sulaco SOURCES]$ sha256sum shared-color-targets-0.0.1.tar.gz*
47d52e4f4c21f88f71cb0332d7b07702c3efbb5fc24afe8b6022000e50db2e49 
shared-color-targets-0.0.1.tar.gz
47d52e4f4c21f88f71cb0332d7b07702c3efbb5fc24afe8b6022000e50db2e49 
shared-color-targets-0.0.1.tar.gz.1
[petro at Sulaco SOURCES]$ 

> > * Relocate docs related to Wolf Faust's work.  
> 
> Not done. Programs such as gnome-color-manager are expecting them to be in
> /usr/share/share-color-targets/$(VENDOR)/{README|LICENSE} -- this is so the
> user can click a link to the target readme or licence in the GUI and it will be
> displayed automatically. They shouldn't be listed as doc files as if they are
> missing then clients can't display the licence of the targets, which is bad.
> 
> I hope this is okay, as functionality in the GUI client depends on the fact
> they are present, and named in this way.
> 
> Richard.
> 
> New spec file:
> http://people.freedesktop.org/~hughsient/temp/shared-color-targets.spec
> New SRPM:
> http://people.freedesktop.org/~hughsient/temp/shared-color-targets-0.0.1-0.7.20091218git.fc12.src.rpm  

Ok, understood. You need to own %{_datadir}/shared-color-targets directory -
that's the only issue remaining.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list