[Bug 548694] Review Request: python-rpmfluff - Lightweight way of building RPMs, and sabotaging them

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548694


James Laska <jlaska at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jlaska at redhat.com




--- Comment #1 from James Laska <jlaska at redhat.com>  2009-12-18 08:40:57 EDT ---
= rpmlint =

$ rpmlint python-rpmfluff-0.3-1.fc12.src.rpm
python-rpmfluff.src: W: spelling-error-in-description en_US rpmlint
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint python-rpmfluff-0.3-1.fc12.noarch.rpm 
python-rpmfluff.noarch: W: spelling-error-in-description en_US rpmlint
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

The above is more of a warning and not something I would expect to cause issue.

= general specfile formatting =

I've made some minor formatting corrections based on the feedback I've always
received from my package reviews.  I don't think this is a requirement, but
might help.

See the changes at ... http://pastie.org/748652

= license =

The spec file lists GPLv2, but there is no LICENSE file in the source or %doc. 
Perhaps someone else can speak to that. 

= copyright =

The rpmfluff.py file has no copyright preamble.  Should one be added?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.