[Bug 549198] Review Request: python-jabberbot - A simple jabber (XMPP) bot framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549198


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review+




--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org>  2009-12-20 18:32:19 EDT ---
Review:

Good:
- name ok
- %files section ok
- permissions ok
- rpmlint clean
- macros everywhere
- %clean is there
- %doc ok
- no *.la files
- no libs
- no gui -> no desktop file
- no translations
- group ok


Needswork:
- Have you queried upstream to include a COPYING file?
  If not yet, please do so.
- BR: python-devel is not needed
- --prefix=%{_prefix} is not needed in %install
- License is GPLv3+ not GPLv3 only


#######################

These are only minor issues, which are fixed easily -> appoving

#######################

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.