[Bug 549198] Review Request: python-jabberbot - A simple jabber (XMPP) bot framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549198





--- Comment #2 from Fabian Affolter <fabian at bernewireless.net>  2009-12-21 04:43:16 EDT ---
Thanks for the review Thomas.

(In reply to comment #1)

> Needswork:
> - Have you queried upstream to include a COPYING file?
>   If not yet, please do so.

I'm waiting for an answer from upstream about that issue.

> - BR: python-devel is not needed

The Guidelines says 'python-devel' must be added because it's no longer in the
default package set.  Am I wrong?

http://fedoraproject.org/wiki/Packaging:Python

> - --prefix=%{_prefix} is not needed in %install

Will be removed

> - License is GPLv3+ not GPLv3 only

Will be fixed

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.