[Bug 549863] Review Request: plexus-interpolation - Plexus Interpolation API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549863


Andrew Overholt <overholt at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |overholt at redhat.com
         AssignedTo|nobody at fedoraproject.org    |overholt at redhat.com
               Flag|                            |fedora-review?




--- Comment #1 from Andrew Overholt <overholt at redhat.com>  2009-12-22 16:43:16 EDT ---
Good:
- builds
- source good (no diffs in my checkout vs. yours packed in the tarball)
- macros fine
- no pre-build JARs
- files fine
- clean present

Needs work:

- line length too long for %description
- should probably get some %doc files
- license should be ASL 2.0 and ASL 1.1 and MIT
- rpmlint output is not clean:

$ rpmlint
/home/overholt/rpmbuild/RPMS/noarch/plexus-interpolation-1.13-1.fc12.noarch.rpm
plexus-interpolation.noarch: E: description-line-too-long Plexus interpolator
is the outgrowth of multiple iterations of development focused on
plexus-interpolation.noarch: E: description-line-too-long providing a more
modular, flexible interpolation framework for the expression language
plexus-interpolation.noarch: W: incoherent-version-in-changelog 1.8-1
['1.13-1.fc12', '1.13-1']
plexus-interpolation.noarch: W: no-documentation
plexus-interpolation.noarch: W: non-conffile-in-etc
/etc/maven/fragments/plexus-interpolation
1 packages and 0 specfiles checked; 2 errors, 3 warnings.
$ rpmlint
/home/overholt/rpmbuild/SRPMS/plexus-interpolation-1.13-1.fc12.src.rpm
plexus-interpolation.src: E: description-line-too-long Plexus interpolator is
the outgrowth of multiple iterations of development focused on
plexus-interpolation.src: E: description-line-too-long providing a more
modular, flexible interpolation framework for the expression language
1 packages and 0 specfiles checked; 2 errors, 0 warnings.
$ rpmlint
/home/overholt/rpmbuild/RPMS/noarch/plexus-interpolation-javadoc-1.13-1.fc12.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.