[Bug 549863] Review Request: plexus-interpolation - Plexus Interpolation API

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 22 21:58:40 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549863





--- Comment #2 from Alexander Kurtakov <akurtako at redhat.com>  2009-12-22 16:58:40 EDT ---
(In reply to comment #1)
> Good:
> - builds
> - source good (no diffs in my checkout vs. yours packed in the tarball)
> - macros fine
> - no pre-build JARs
> - files fine
> - clean present
> 
> Needs work:
> 
> - line length too long for %description
Fixed.
> - should probably get some %doc files
There is nothing suitable.
> - license should be ASL 2.0 and ASL 1.1 and MIT
Fixed.

> - rpmlint output is not clean:
> 
Output now is but both are fase positives.:
plexus-interpolation.noarch: W: no-documentation
plexus-interpolation.noarch: W: non-conffile-in-etc
/etc/maven/fragments/plexus-interpolation

New sources:
Spec URL: http://akurtakov.fedorapeople.org/plexus-interpolation.spec
SRPM URL:
http://akurtakov.fedorapeople.org/plexus-interpolation-1.13-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list