[Bug 483846] Review Request: gsim85 - An 8085 microprocessor simulator
bugzilla at redhat.com
bugzilla at redhat.com
Tue Feb 3 23:41:29 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483846
manuel wolfshant <wolfy at nobugconsulting.ro> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |wolfy at nobugconsulting.ro
Flag| |fedora-review?
--- Comment #1 from manuel wolfshant <wolfy at nobugconsulting.ro> 2009-02-03 18:41:28 EDT ---
There is a small cosmetic issue with the desktop file: the icon should either
contain the full path to the file or just the name (without extension). Your
desktop file contains name.extension.
As a minor non-blocking issue, you have a duplicate BR, gtk2-devel is brought
in by libglade2-devel.
It would be awesome if you also convince the installer to preserve the
timestamps of the pixmaps. Given the build log, I'd say that adding
INSTALL="install -p" to "make install "should do it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list