[Bug 483846] Review Request: gsim85 - An 8085 microprocessor simulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483846





--- Comment #2 from Fabian Affolter <fabian at bernewireless.net>  2009-02-03 19:15:23 EDT ---
Thanks for your inputs

(In reply to comment #1)
> There is a small cosmetic issue with the desktop file: the icon should either
> contain the full path to the file or just the name (without extension). Your
> desktop file contains name.extension.

Added a small patch

> As a minor non-blocking issue, you have a duplicate BR, gtk2-devel is brought
> in by libglade2-devel.

fixed 

> It would be awesome if you also convince the installer to preserve the
> timestamps of the pixmaps. Given the build log, I'd say that adding
> INSTALL="install -p" to "make install "should do it.

fixed

Here are the updated files

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/gsim85.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/gsim85-0.2-2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.