[Bug 225744] Merge Review: fbset

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225744





--- Comment #4 from Adrian Reber <adrian at lisas.de>  2009-02-05 08:52:40 EDT ---
There is something in the guidelines about %makeinstall:

http://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

The right thing, to conform with the guidelines would be to use:

make install sysconfdir=%{buildroot}%{_sysconfdir}
sbindir=%{buildroot}%{_sbindir} mandir=%{buildroot}%{_mandir}

Although, that makes it pretty unreadable. I would say it is up to you which
one you like better.

And I have seen this:

MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.

There is tracker bug for s390 at:
https://bugzilla.redhat.com/show_bug.cgi?id=467765

Please create a bug blocking that one and mention the bug near the ExcludeArch
line.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.