[Bug 225744] Merge Review: fbset

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225744





--- Comment #5 from Zdenek Prikryl <zprikryl at redhat.com>  2009-02-10 04:29:42 EDT ---
(In reply to comment #4)
> There is something in the guidelines about %makeinstall:
> 
> http://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
> 

Since "make install DESTDIR=%{buildroot}" doesn't work and fbset doesn't use
libtool or autotools stuff, I'd not remove the %makeinstall macro.

> And I have seen this:
> 
> MUST: If the package does not successfully compile, build or work on an
> architecture, then those architectures should be listed in the spec in
> ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
> bugzilla, describing the reason that the package does not compile/build/work on
> that architecture. The bug number MUST be placed in a comment, next to the
> corresponding ExcludeArch line.
> 

I created the bug and write ID to the spec file. Check cvs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.