[Bug 484676] Review Request: eclipse-dtp - Eclipse Data Tools Platform

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484676





--- Comment #2 from Andrew Overholt <overholt at redhat.com>  2009-02-10 12:15:13 EDT ---
These minor things still stand:

(In reply to comment #1)
> - change the Requires: on java to be >= (or maybe '='?) 1.5.0
> - I prefer to add a short name after dropins:
>   %files
>   %{eclipse_dropin} => %{eclipse_dropin}/dtp
> - please add a comment above the sed line getting rid of the sun.misc.Compare
> - should we add some comment(s) stating why we're only building the features we
> are?

This last point is important.  Since we're not shipping any of the user-visible
features, we need to stress this.  Ideally we'd have a bug for building all of
DTP and then dependent bugs for any packages we need and/or modifications we
need in other packages.

> X verify the final provides and requires of the binary RPMs
>   - other than the java one, things look good
> X make sure lines are <= 80 characters
>   - could you add some line continuations to fix this?

* package successfully compiles and builds

I evidently needed the rawhide SDK to build this.  We'll have to do an update
if we want this to be in Fedora 10, I guess.  It all builds and installs (and
is present after installation) fine now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.