[Bug 484676] Review Request: eclipse-dtp - Eclipse Data Tools Platform

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484676





--- Comment #3 from Alexander Kurtakov <akurtako at redhat.com>  2009-02-11 15:47:28 EDT ---
Spec URL:
http://akurtakov.fedorapeople.org/eclipse-dtp.spec
SRPM URL:
http://akurtakov.fedorapeople.org/eclipse-dtp-1.6.1-2.fc10.src.rpm



(In reply to comment #1)
> A few minor things:
> 
> - please set the fedora-review flag to ?
> - change the Requires: on java to be >= (or maybe '='?) 1.5.0
Fixed.

> - I prefer to add a short name after dropins:
>   %files
>   %{eclipse_dropin} => %{eclipse_dropin}/dtp
Fixed.

> - please add a comment above the sed line getting rid of the sun.misc.Compare
Fixed.

> - should we add some comment(s) stating why we're only building the features we
> are?
Fixed.

> 
> And the rest of the review (lines beginning with X need attention; those
> beginning with * are okay):
> 
> X verify the final provides and requires of the binary RPMs
>   - other than the java one, things look good
Fixed.

> X make sure lines are <= 80 characters
>   - could you add some line continuations to fix this?
Fixed wherever possible some paths are just too long.

> X package successfully compiles and builds
>   - is this expected?
> 
>     [javac] 4. ERROR in
> /home/overholt/rpmbuild/BUILD/dtp-1.6.1/build/plugins/org.eclipse.datatools.connectivity.oda.design/src/org/eclipse/datatools/connectivity/oda/design/impl/InputElementUIHintsImpl.java
>     [javac]  (at line 112)
>     [javac]  assert (eContainer() instanceof InputElementAttributes);
>     [javac]  ^^^^^^
>     [javac] The method assert(boolean) is undefined for the type
> InputElementUIHintsImpl
> 
Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.