[Bug 470727] Review Request: slimdata - Tools and library for reading and writing slim compressed data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470727





--- Comment #11 from Lucian Langa <cooly at gnome.eu.org>  2009-02-24 11:00:18 EDT ---
Thanks for the update.

Package fails to build under mock for rawhide (gcc 4.4).
Mainly because of gcc headers cleanup some headers now are not included by
default or indirectly through some other headers.
please consider the following patch:

--- slim-2.6.1b/include/slim.h  2008-11-07 00:46:47.000000000 +0200
+++ slim-2.6.1b-mod/include/slim.h      2009-02-24 15:22:57.000000000 +0200
@@ -8,9 +8,11 @@
 #define SLIM_H

 #include <iostream>
+#include <cstdio>
 #include <cstdlib>
 #include <cassert>
 #include <cstring>   // for strlen, strcpy
+#include <stdint.h>

 #define SLIM_VERSION "v2_6_0"

--- slim-2.6.1b/src/slim_control.cpp    2008-11-07 00:46:48.000000000 +0200
+++ slim-2.6.1b-mod/src/slim_control.cpp        2009-02-24 15:51:01.000000000
+0200
@@ -503,7 +503,7 @@
   // Normally, this means stripping any trailing dot-suffix.
   // But if we have --preserve, then append a ".raw" suffix instead.
   char *rawname;
-  char *last_suffix = strrchr(compname,'.');
+  const char *last_suffix = strrchr(compname,'.');
   size_t baselen;
   if (last_suffix)
     baselen = (last_suffix-compname);

it would be nice to send it upstream too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.