[Bug 455226] Review Request: php-pecl-runkit - PHP Opcode Analyser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455226





--- Comment #11 from Remi Collet <fedora at famillecollet.com>  2009-02-24 11:13:36 EDT ---
Why do you use 
    install modules/%{peclName}.so %{buildroot}%{php_extdir}

Rather than (which also create the destination dir)
    make install INSTALL_ROOT=$RPM_BUILD_ROOT


Doesn't build for me :
- %doc %{peclName}-%{version}/README
+ %doc %{peclName}/README

rpmlint : 
php-pecl-runkit.src: I: checking
php-pecl-runkit.src:39: W: unversioned-explicit-obsoletes php-pear-%{peclName}
php-pecl-runkit.src: W: summary-not-capitalized runkit - mangle with user
defined functions and classes
php-pecl-runkit.src: W: non-standard-group Development/Languages/PHP
php-pecl-runkit.x86_64: I: checking
php-pecl-runkit.x86_64: W: summary-not-capitalized runkit - mangle with user
defined functions and classes
php-pecl-runkit.x86_64: W: non-standard-group Development/Languages/PHP
php-pecl-runkit.x86_64: W: obsolete-not-provided php-pear-runkit
php-pecl-runkit-debuginfo.x86_64: I: checking
php-pecl-runkit.spec:39: W: unversioned-explicit-obsoletes php-pear-%{peclName}
3 packages and 1 specfiles checked; 0 errors, 7 warnings.

Most of them can be fixed easily

- stuff php-pear-%{peclName} is not usefull in Fedora (php-pear-runkit don't
exists AFAIK)
- %{peclName} could be removed from desc and first word capitalized.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.