[Bug 470727] Review Request: slimdata - Tools and library for reading and writing slim compressed data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470727





--- Comment #13 from Lucian Langa <cooly at gnome.eu.org>  2009-02-26 05:40:38 EDT ---
Review: 

OK source files match upstream:
        c69db6265da59079263043dc5f5540e67f6d35cabed54016a17a5e82f31326d2 
slim-2.6.1b.tgz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK summary a short and concise description.
OK description is OK.
OK dist tag is present.
OK build root is sane.
NOT OK license field matches the actual license.
OK license is open source-compatible.
OK license text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (rawhide, x86_64).
OK package installs properly.
OK debuginfo package looks complete.
OK rpmlint has acceptable warnings.
OK final provides and requires are sane:
slimdata-2.6.1b-4.fc11.x86_64.rpm
        libslim.so.0()(64bit)
        slimdata = 2.6.1b-4.fc11
        slimdata(x86-64) = 2.6.1b-4.fc11
=
        /sbin/ldconfig
        libc.so.6()(64bit)
        libgcc_s.so.1()(64bit)
        libm.so.6()(64bit)
        libslim.so.0()(64bit)
        libstdc++.so.6()(64bit)
slimdata-devel-2.6.1b-4.fc11.x86_64.rpm
        slimdata-devel = 2.6.1b-4.fc11
        slimdata-devel(x86-64) = 2.6.1b-4.fc11
=
        libslim.so.0()(64bit)
        pkgconfig
        slimdata = 2.6.1b-4.fc11
OK %check is present and all tests pass:
Running compression data-type tests on /tmp/data_partial.bin (size 1000000)...
...Passed all 8 data-type tests
Running compression tests on /tmp/data_partial.bin (size 1000000)...
...Passed all 16 compression tests
Running expansion tests on /tmp/data_partial.bin (size 1000000)...
...Passed all 17 expansion tests
Running compression data-type tests on /tmp/data_partial.bin (size 1000003)...
...Passed all 8 data-type tests
Running compression data-type tests on /tmp/data_partial.bin (size 524289)...
...Passed all 8 data-type tests
Running compression data-type tests on /tmp/data_partial.bin (size 524287)...
...Passed all 8 data-type tests
Running compression data-type tests on /tmp/fake_test_data.bin (size
20000000)...
...Passed all 8 data-type tests
Running compression tests on /tmp/fake_test_data.bin (size 20000000)...
...Passed all 16 compression tests
Running expansion tests on /tmp/fake_test_data.bin (size 20000000)...
...Passed all 2 expansion tests
OK shared libraries are present, ldconfig called properly
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers are in a separate -devel package.
OK no pkgconfig files.
OK no libtool .la droppings.

Blocker: License field should be GPL+

Suggestions: please consider preserving timestamps of installed files (adding
INSTALL="install -p" to make install target in %install section)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.